Copilot commented on code in PR #9781: URL: https://github.com/apache/gravitino/pull/9781#discussion_r2716107156
########## docs/how-to-install.md: ########## @@ -19,9 +19,11 @@ The Gravitino package comprises both the Gravitino server and the Gravitino Iceb Before installing Gravitino, make sure you have the Gravitino binary distribution package. You can download the latest Gravitino binary distribution package from [GitHub](https://github.com/apache/gravitino/releases). You can also build it yourself by following the instructions in [How to Build Gravitino](./how-to-build.md). - - If you build Gravitino yourself using the `./gradlew compileDistribution` command, you can find the Gravitino binary distribution package in the `distribution/package` directory. + - If you build Gravitino yourself using the `./gradlew compileDistribution` command, you can find the Gravitino binary distribution package in the `distribution/package` and `distribution/package-extend` directory. The main difference between these two packages is that the `package-extend` package contains all catalogs including catalog under folder `catalogs-contrib` while the `package` package only contains the main catalogs under folder `catalogs`. - - If you build Gravitino yourself using the `./gradlew assembleDistribution` command, you can get the compressed Gravitino binary distribution package with the name `gravitino-<version>-bin.tar.gz` in the `distribution` directory with sha256 checksum file `gravitino-<version>-bin.tar.gz.sha256`. + - If you build Gravitino yourself using the `./gradlew assembleDistribution` command, you can get the compressed Gravitino binary distribution package with the name `gravitino-<version>-bin.tar.gz` in the `distribution` directory with sha256 checksum file `gravitino-<version>-bin.tar.gz.sha256` and the extended compressed Gravitino binary distribution package with the name `gravitino-<version>-bin-extend.tar.gz` in the `distribution` directory with sha256 checksum file `gravitino-<version>-bin-extend.tar.gz.sha256`. The main difference between these two packages is that the `-extend` package contains all catalogs including catalog under folder `catalogs-contrib` while the normal package only contains the main catalogs under folder `catalogs`. Review Comment: The documentation contains a long line that should be broken into multiple lines for better readability. Lines 22 and 24 exceed typical line length guidelines and make the documentation harder to read. ########## catalogs-contrib/build.gradle.kts: ########## @@ -0,0 +1,22 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + Review Comment: The catalogs-contrib/build.gradle.kts disables all tasks by default. This appears intentional to exclude contrib catalogs from the standard build, but it may cause confusion. Consider adding a comment explaining why all tasks are disabled and how to enable them when needed. ```suggestion // Disable all tasks in this module by default so that contrib catalogs are // not built as part of the standard Gravitino build. If you need to build // or test a contrib catalog locally, temporarily remove or adjust this block // to re-enable the relevant tasks. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
