yuqi1129 commented on code in PR #9773:
URL: https://github.com/apache/gravitino/pull/9773#discussion_r2716912028


##########
core/src/main/java/org/apache/gravitino/cache/ReverseIndexCache.java:
##########
@@ -72,7 +72,7 @@ public class ReverseIndexCache {
    * or the data will be in the memory forever.
    */
   private final Map<EntityCacheKey, List<EntityCacheKey>> 
entityToReverseIndexMap =
-      Maps.newHashMap();
+      Maps.newConcurrentMap();

Review Comment:
   I will take time on it. 



##########
core/src/main/java/org/apache/gravitino/authorization/UserGroupManager.java:
##########
@@ -105,18 +99,8 @@ boolean removeUser(String metalake, String user) {
 
   User getUser(String metalake, String user) throws NoSuchUserException {
     try {
-      // Only check metalake existence, not enabled status, to allow reading 
user info
-      // on disabled metalakes for internal operations like checkCurrentUser().

Review Comment:
   Why do we remove it? it appear that this change has nothing to do with 
`checkMetalakeInUse` logic. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to