mxdzs0612 opened a new issue, #9798:
URL: https://github.com/apache/gravitino/issues/9798

   ### Version
   
   main branch
   
   ### Describe what's wrong
   
   Cannot update hive partition columns' comment because there is no partition 
column in sd.getCols.
   
   ### Error message and/or stacktrace
   
   ```
   2026-01-26 10:24:44.450 WARN [Gravitino-webserver-13206] 
[org.apache.gravitino.server.web.rest.ExceptionHandlers$TableExceptionHandler.handle(ExceptionHandlers.java:259)]
 - Failed to operate table(s) [safe_table_hive_date_0123] operation [ALTER] 
under schema [dm], reason [Index -1 out of bounds for length 5]
   java.lang.RuntimeException: java.lang.IndexOutOfBoundsException: Index -1 
out of bounds for length 5
        at 
org.apache.gravitino.catalog.hive.HiveCatalogOperations.alterTable(HiveCatalogOperations.java:955)
 ~[?:?]
        at 
org.apache.gravitino.catalog.TableOperationDispatcher.lambda$alterTable$7(TableOperationDispatcher.java:221)
 ~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.catalog.CatalogManager$CatalogWrapper.lambda$doWithTableOps$1(CatalogManager.java:160)
 ~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.utils.IsolatedClassLoader.withClassLoader(IsolatedClassLoader.java:90)
 ~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.catalog.CatalogManager$CatalogWrapper.doWithTableOps(CatalogManager.java:155)
 ~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.catalog.TableOperationDispatcher.lambda$alterTable$8(TableOperationDispatcher.java:220)
 ~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.catalog.OperationDispatcher.doWithCatalog(OperationDispatcher.java:122)
 ~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.catalog.TableOperationDispatcher.lambda$alterTable$14(TableOperationDispatcher.java:217)
 ~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.lock.TreeLockUtils.doWithTreeLock(TreeLockUtils.java:49) 
~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.catalog.TableOperationDispatcher.alterTable(TableOperationDispatcher.java:211)
 ~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.hook.TableHookDispatcher.alterTable(TableHookDispatcher.java:111)
 ~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.catalog.TableNormalizeDispatcher.alterTable(TableNormalizeDispatcher.java:94)
 ~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.listener.TableEventDispatcher.alterTable(TableEventDispatcher.java:156)
 ~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.server.web.rest.TableOperations.lambda$alterTable$4(TableOperations.java:228)
 ~[gravitino-server-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
java.base/java.security.AccessController.doPrivileged(AccessController.java:712)
 ~[?:?]
        at java.base/javax.security.auth.Subject.doAs(Subject.java:439) ~[?:?]
        at 
org.apache.gravitino.utils.PrincipalUtils.doAs(PrincipalUtils.java:44) 
~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at org.apache.gravitino.server.web.Utils.doAs(Utils.java:286) 
~[gravitino-server-common-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.server.web.rest.TableOperations.alterTable(TableOperations.java:219)
 ~[gravitino-server-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.server.web.rest.TableOperations_$$_jvst4e0_2._d1alterTable(TableOperations_$$_jvst4e0_2.java)
 ~[gravitino-server-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at jdk.internal.reflect.GeneratedMethodAccessor135.invoke(Unknown 
Source) ~[?:?]
        at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:?]
        at java.base/java.lang.reflect.Method.invoke(Method.java:569) ~[?:?]
        at 
org.glassfish.hk2.utilities.reflection.ReflectionHelper.invoke(ReflectionHelper.java:1268)
 ~[hk2-utils-2.6.1.jar:?]
        at 
org.jvnet.hk2.internal.MethodInterceptorHandler$MethodInvocationImpl.proceed(MethodInterceptorHandler.java:164)
 ~[hk2-locator-2.6.1.jar:?]
        at 
org.apache.gravitino.server.web.filter.GravitinoInterceptionService$MetadataAuthorizationMethodInterceptor.invoke(GravitinoInterceptionService.java:152)
 ~[gravitino-server-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.jvnet.hk2.internal.MethodInterceptorHandler.invoke(MethodInterceptorHandler.java:97)
 ~[hk2-locator-2.6.1.jar:?]
        at 
org.apache.gravitino.server.web.rest.TableOperations_$$_jvst4e0_2.alterTable(TableOperations_$$_jvst4e0_2.java)
 ~[gravitino-server-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at jdk.internal.reflect.GeneratedMethodAccessor134.invoke(Unknown 
Source) ~[?:?]
        at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:?]
        at java.base/java.lang.reflect.Method.invoke(Method.java:569) ~[?:?]
        at 
org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory.lambda$static$0(ResourceMethodInvocationHandlerFactory.java:52)
 ~[jersey-server-2.41.jar:?]
        at 
org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:146)
 ~[jersey-server-2.41.jar:?]
        at 
org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:189)
 ~[jersey-server-2.41.jar:?]
        at 
org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$ResponseOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:176)
 ~[jersey-server-2.41.jar:?]
        at 
org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:93)
 ~[jersey-server-2.41.jar:?]
        at 
org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:478)
 ~[jersey-server-2.41.jar:?]
        at 
org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:400)
 ~[jersey-server-2.41.jar:?]
        at 
org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:81)
 ~[jersey-server-2.41.jar:?]
        at 
org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:256) 
~[jersey-server-2.41.jar:?]
        at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248) 
~[jersey-common-2.41.jar:?]
        at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244) 
~[jersey-common-2.41.jar:?]
        at org.glassfish.jersey.internal.Errors.process(Errors.java:292) 
~[jersey-common-2.41.jar:?]
        at org.glassfish.jersey.internal.Errors.process(Errors.java:274) 
~[jersey-common-2.41.jar:?]
        at org.glassfish.jersey.internal.Errors.process(Errors.java:244) 
~[jersey-common-2.41.jar:?]
        at 
org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:265)
 ~[jersey-common-2.41.jar:?]
        at 
org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:235) 
~[jersey-server-2.41.jar:?]
        at 
org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:684)
 ~[jersey-server-2.41.jar:?]
        at 
org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:394) 
~[jersey-container-servlet-core-2.41.jar:?]
        at 
org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:346) 
~[jersey-container-servlet-core-2.41.jar:?]
        at 
org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:358)
 ~[jersey-container-servlet-core-2.41.jar:?]
        at 
org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:311)
 ~[jersey-container-servlet-core-2.41.jar:?]
        at 
org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205)
 ~[jersey-container-servlet-core-2.41.jar:?]
        at 
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799) 
~[jetty-servlet-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1656)
 ~[jetty-servlet-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.apache.gravitino.server.authentication.AuthenticationFilter.lambda$doFilter$0(AuthenticationFilter.java:105)
 ~[gravitino-server-common-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
java.base/java.security.AccessController.doPrivileged(AccessController.java:712)
 ~[?:?]
        at java.base/javax.security.auth.Subject.doAs(Subject.java:439) ~[?:?]
        at 
org.apache.gravitino.utils.PrincipalUtils.doAs(PrincipalUtils.java:44) 
~[gravitino-core-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.apache.gravitino.server.authentication.AuthenticationFilter.doFilter(AuthenticationFilter.java:102)
 ~[gravitino-server-common-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193) 
~[jetty-servlet-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
 ~[jetty-servlet-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.apache.gravitino.server.web.VersioningFilter.doFilter(VersioningFilter.java:111)
 ~[gravitino-server-1.0.0-mdh-1.0.0-SNAPSHOT.jar:?]
        at 
org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193) 
~[jetty-servlet-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
 ~[jetty-servlet-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:552) 
~[jetty-servlet-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) 
~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600) 
~[jetty-security-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) 
~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
 ~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
 ~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
 ~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440)
 ~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
 ~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505) 
~[jetty-servlet-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
 ~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
 ~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355)
 ~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) 
~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146)
 ~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) 
~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at org.eclipse.jetty.server.Server.handle(Server.java:516) 
~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487) 
~[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732) 
[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479) 
[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277) 
[jetty-server-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
 [jetty-io-9.4.51.v20230217.jar:9.4.51.v20230217]
        at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105) 
[jetty-io-9.4.51.v20230217.jar:9.4.51.v20230217]
        at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104) 
[jetty-io-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338)
 [jetty-util-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315)
 [jetty-util-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173)
 [jetty-util-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131)
 [jetty-util-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:409)
 [jetty-util-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
 [jetty-util-9.4.51.v20230217.jar:9.4.51.v20230217]
        at 
org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
 [jetty-util-9.4.51.v20230217.jar:9.4.51.v20230217]
        at java.base/java.lang.Thread.run(Thread.java:840) [?:?]
   Caused by: java.lang.IndexOutOfBoundsException: Index -1 out of bounds for 
length 5
        at 
java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64) 
~[?:?]
        at 
java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
 ~[?:?]
        at 
java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266) 
~[?:?]
        at java.base/java.util.Objects.checkIndex(Objects.java:361) ~[?:?]
        at java.base/java.util.ArrayList.get(ArrayList.java:427) ~[?:?]
        at 
org.apache.gravitino.catalog.hive.HiveCatalogOperations.doUpdateColumnComment(HiveCatalogOperations.java:1056)
 ~[?:?]
        at 
org.apache.gravitino.catalog.hive.HiveCatalogOperations.alterTable(HiveCatalogOperations.java:904)
 ~[?:?]
        ... 96 more
   ```
   
   ### How to reproduce
   
   Update a hive table's partition column's comment. See ` 
org.apache.gravitino.catalog.hive.HiveCatalogOperations.alterTable()`
   
   ```java
   } else if (change instanceof TableChange.ColumnChange) {
       // Column change
       StorageDescriptor sd = alteredHiveTable.getSd();
       List<FieldSchema> cols = sd.getCols();
   
       if (change instanceof TableChange.AddColumn) {
         TableChange.AddColumn addColumn = (TableChange.AddColumn) change;
         doAddColumn(cols, addColumn);
   
       } else if (change instanceof TableChange.DeleteColumn) {
         doDeleteColumn(cols, (TableChange.DeleteColumn) change);
   
       } else if (change instanceof TableChange.RenameColumn) {
         doRenameColumn(cols, (TableChange.RenameColumn) change);
   
       } else if (change instanceof TableChange.UpdateColumnComment) {
         doUpdateColumnComment(cols, (TableChange.UpdateColumnComment) change);
   
       } else if (change instanceof TableChange.UpdateColumnPosition) {
         doUpdateColumnPosition(cols, (TableChange.UpdateColumnPosition) 
change);
   
       } else if (change instanceof TableChange.UpdateColumnType) {
         doUpdateColumnType(cols, (TableChange.UpdateColumnType) change);
   
       } else if (change instanceof TableChange.UpdateColumnAutoIncrement) {
         throw new IllegalArgumentException(
             "Hive does not support altering column auto increment");
       } else {
         throw new IllegalArgumentException(
             "Unsupported column change type: " + 
change.getClass().getSimpleName());
       }
   ```
   
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to