Copilot commented on code in PR #9689:
URL: https://github.com/apache/gravitino/pull/9689#discussion_r2730315598
##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/hive/HiveSchemaAndTablePropertiesConverter.java:
##########
@@ -108,6 +109,18 @@ public Map<String, String>
toGravitinoTableProperties(Map<String, String> flinkP
if (formatRaw != null) {
properties.put(HiveConstants.FORMAT, formatRaw);
}
+
+ String connector = properties.get(FlinkGenericTableUtil.CONNECTOR);
+
+ // remove connector from properties to keep compatibility with Flink's
behavior
+ if (connector != null) {
+ Preconditions.checkArgument(
+ "hive".equalsIgnoreCase(connector),
+ "The connector type must be hive, but get %s",
+ FlinkGenericTableUtil.CONNECTOR);
Review Comment:
The error message format is incorrect. The placeholder %s should be replaced
with the actual connector value, not the constant name. The third argument
should be 'connector' instead of 'FlinkGenericTableUtil.CONNECTOR'.
```suggestion
connector);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
