jerryshao commented on code in PR #9127:
URL: https://github.com/apache/gravitino/pull/9127#discussion_r2733314958
##########
core/src/main/java/org/apache/gravitino/connector/GenericTable.java:
##########
@@ -68,4 +68,20 @@ protected GenericTable internalBuild() {
return table;
}
}
+
+ // Copy the current table and set new properties
+ public GenericTable setProperties(String key, String value) {
+ GenericTable table = new GenericTable();
+ table.columns = this.columns;
+ table.comment = this.comment;
+ table.properties = this.properties;
+ table.auditInfo = this.auditInfo;
+ table.distribution = this.distribution;
+ table.indexes = this.indexes;
+ table.name = this.name;
+ table.partitioning = this.partitioning;
+ table.sortOrders = this.sortOrders;
+ table.properties.put(key, value);
+ return table;
+ }
Review Comment:
Why don't you use the builder method here, instead of adding a weird method
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
