Copilot commented on code in PR #9811:
URL: https://github.com/apache/gravitino/pull/9811#discussion_r2734543494
##########
docs/lakehouse-iceberg-catalog.md:
##########
@@ -34,12 +34,12 @@ Builds with Apache Iceberg `1.10.0`. The Apache Iceberg
table format version is
### Catalog properties
-| Property name | Description
| Default value
| Required | Since
Version |
-|------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------------------------------------------------------------------|----------|---------------|
-| `catalog-backend` | Catalog backend of Gravitino Iceberg catalog.
Supports `hive` or `jdbc` or `rest`.
| (none)
| Yes |
0.2.0 |
-| `uri` | The URI configuration of the Iceberg catalog.
`thrift://127.0.0.1:9083` or `jdbc:postgresql://127.0.0.1:5432/db_name` or
`jdbc:mysql://127.0.0.1:3306/metastore_db` or `http://127.0.0.1:9001`. | (none)
| Yes
| 0.2.0 |
-| `warehouse` | Warehouse directory of catalog.
`file:///user/hive/warehouse-hive/` for local fs or
`hdfs://namespace/hdfs/path` for HDFS.
| (none)
| Yes | 0.2.0 |
-| `catalog-backend-name` | The catalog name passed to underlying Iceberg
catalog backend. Catalog name in JDBC backend is used to isolate namespace and
tables. | The
property value of `catalog-backend`, like `jdbc` for JDBC catalog backend. | No
| 0.5.2 |
+| Property name | Description
| Default
value |
Required | Since Version |
+|------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------------------------------------------------------------------|-------------------------------------------|---------------|
+| `catalog-backend` | Catalog backend of Gravitino Iceberg catalog.
Supports `hive` or `jdbc` or `rest`.
|
(none)
| Yes | 0.2.0 |
+| `uri` | The URI configuration of the Iceberg catalog.
`thrift://127.0.0.1:9083` or `jdbc:postgresql://127.0.0.1:5432/db_name` or
`jdbc:mysql://127.0.0.1:3306/metastore_db` or `http://127.0.0.1:9001/iceberg`.
| (none)
| Yes | 0.2.0 |
+| `warehouse` | Warehouse location of catalog. Use a physical s3 or
HDFS location for `hive` or `jdbc` catalog backend, use catalog name for REST
catalog backend. | (none)
| Yes
for `hive` and `jdbc` catalog backend | 0.2.0 |
Review Comment:
The lowercase "s3" should be capitalized to "S3" to maintain consistency
with the rest of the documentation. Throughout this document and related
documentation files, "S3" is consistently capitalized when referring to the AWS
S3 service or storage type.
##########
docs/lakehouse-iceberg-catalog.md:
##########
@@ -67,6 +67,28 @@ You must download the corresponding JDBC driver and place it
to the `catalogs/la
If you are using multiple JDBC catalog backends, setting `jdbc-initialize` to
true may not take effect for RDMS like `Mysql`, you should create Iceberg meta
tables explicitly.
:::
+#### REST catalog backend
+
+For the REST catalog backend, `warehouse` identifies the catalog in the
Iceberg REST spec. In the Gravitino Iceberg REST server, `warehouse` maps to
the catalog name. An empty value means the default catalog.
+
+Example: create an Iceberg catalog with the REST backend. This targets the
default catalog and uses a REST path like
`http://127.0.0.1:9001/iceberg/v1/namespaces/db/tables/table`.
+
+```shell
+curl -X POST -H "Content-Type: application/json" \
Review Comment:
The curl command should include the Accept header for consistency with other
catalog creation examples in the main documentation. Examples in
manage-relational-metadata-using-gravitino.md and
manage-metalake-using-gravitino.md consistently use `-H "Accept:
application/vnd.gravitino.v1+json"` when creating catalogs. Consider adding
this header before the Content-Type header.
```suggestion
curl -X POST -H "Accept: application/vnd.gravitino.v1+json" -H
"Content-Type: application/json" \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
