diqiu50 commented on code in PR #9735:
URL: https://github.com/apache/gravitino/pull/9735#discussion_r2734689831
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoSplitSource.java:
##########
@@ -49,11 +49,15 @@ public CompletableFuture<ConnectorSplitBatch>
getNextBatch(int maxSize) {
.thenApply(
batch -> {
List<ConnectorSplit> list =
-
batch.getSplits().stream().map(GravitinoSplit::new).collect(Collectors.toList());
+
batch.getSplits().stream().map(this::createSplit).collect(Collectors.toList());
return new ConnectorSplitBatch(list, batch.isNoMoreSplits());
});
}
+ protected ConnectorSplit createSplit(ConnectorSplit split) {
+ throw new RuntimeException("Should be overridden in subclass");
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
