jerryshao commented on code in PR #9759:
URL: https://github.com/apache/gravitino/pull/9759#discussion_r2737660399
##########
bin/gravitino.sh.template:
##########
@@ -181,6 +181,31 @@ fi
addJarInDir "${GRAVITINO_HOME}/libs"
+# By default, prefer starting the legacy (old) UI war if present.
+# Users may override by setting GRAVITINO_WAR to an explicit path, or
+# set GRAVITINO_USE_OLD_UI=false to prefer the non-old war when both exist.
+if [[ -z "${GRAVITINO_WAR+x}" || -z "${GRAVITINO_WAR}" ]]; then
+ # Compose expected war paths based on packaged layout and version
+ OLD_WAR_PATH="${GRAVITINO_HOME}/web/gravitino-web-1.1.0-old.war"
+ NEW_WAR_PATH="${GRAVITINO_HOME}/web/gravitino-web-${GRAVITINO_VERSION}.war"
Review Comment:
Ideally, we should not use old/new to differentiate the packages; we should
have a version information to distinguish. I would suggest to use v1 as old UI,
v2 as a new UI. Can you change all the varaibles, package name, folder names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
