yuqi1129 commented on code in PR #9815:
URL: https://github.com/apache/gravitino/pull/9815#discussion_r2741205257
##########
core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/postgresql/OwnerMetaPostgreSQLProvider.java:
##########
@@ -135,4 +35,10 @@ public String deleteOwnerMetasByLegacyTimeline(
+ OWNER_TABLE_NAME
+ " WHERE deleted_at > 0 AND deleted_at < #{legacyTimeline} LIMIT
#{limit})";
}
+
+ @Override
+ protected String softDeleteSQL(Optional<String> tableAlias) {
+ // PostgreSQL doesn't support alias prefix in SET clause
+ return " SET deleted_at = CAST(EXTRACT(EPOCH FROM CURRENT_TIMESTAMP) *
1000 AS BIGINT) ";
Review Comment:
It can reduce redundant codes, but possibly it will break the SQL integrity,
making the whole SQL less intuitive. So will it repeat many times?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
