sabashaikh4 commented on code in PR #9854:
URL: https://github.com/apache/gravitino/pull/9854#discussion_r2753560186
##########
core/src/main/java/org/apache/gravitino/listener/api/event/ListTopicFailureEvent.java:
##########
@@ -40,6 +41,7 @@ public final class ListTopicFailureEvent extends
TopicFailureEvent {
*/
public ListTopicFailureEvent(String user, Namespace namespace, Exception
exception) {
super(user, NameIdentifier.of(namespace.levels()), exception);
+ Preconditions.checkNotNull(namespace, "namespace must not be null");
Review Comment:
@jerryshao Thank you for the review! I've updated the code to:
1. Move the check before `super()`
2. Use `checkArgument` instead of `checkNotNull`
3. Update the test to expect `IllegalArgumentException`
Changes are pushed. Please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
