jerryshao commented on code in PR #9872: URL: https://github.com/apache/gravitino/pull/9872#discussion_r2768337720
########## api/src/main/java/org/apache/gravitino/function/FunctionDefinition.java: ########## @@ -18,21 +18,53 @@ */ package org.apache.gravitino.function; +import javax.annotation.Nullable; import org.apache.gravitino.annotation.Evolving; +import org.apache.gravitino.rel.types.Type; /** - * A function definition that pairs a specific parameter list with its implementations. A single - * function can include multiple definitions (overloads), each with distinct parameters and - * implementations. + * A function definition that pairs a specific parameter list with its implementations and return + * type. A single function can include multiple definitions (overloads), each with distinct + * parameters, return types, and implementations. Review Comment: Do we use return types to distinguish different definitions? I remembered that we only honor the parameters, can you clarify it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
