tsungchih commented on code in PR #9870:
URL: https://github.com/apache/gravitino/pull/9870#discussion_r2776742678
##########
clients/client-python/gravitino/dto/rel/indexes/index_dto.py:
##########
@@ -47,6 +49,10 @@ def __init__(
self._name = name
self._field_names = field_names
+ @staticmethod
+ def builder() -> IndexDTO.Builder:
Review Comment:
I'm curious why we need a builder method. IMHO, it is possible to prevent
the caller from initiating an instance directly and use the builder method in
Java. However, we cannot implement it in Python that way so far as I know. The
user can still directly initiate an instance even we provide the builder
method. In this case, do we still need to provide the builder method? And why
do we need to provide the builder method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
