roryqi commented on code in PR #9914:
URL: https://github.com/apache/gravitino/pull/9914#discussion_r2778683400
##########
core/src/main/java/org/apache/gravitino/storage/relational/RelationalEntityStore.java:
##########
@@ -225,6 +227,27 @@ public <E extends Entity & HasIdentifier> List<E>
listEntitiesByRelation(
});
}
+ @Override
+ public <E extends Entity & HasIdentifier> List<E> listEntitiesByRelation(
Review Comment:
You should return a list of relations, otherwise you can't know the relation
between entities.
For example, you list entity1 and entity2 and return entity3, entity4.
The relation is
entity1 -> entity3
entity1 -> entity4
entity2 -> entity3
or
entity1 -> entity3
entity1 -> entity4
entity2 -> entity4
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
