roryqi commented on code in PR #9939:
URL: https://github.com/apache/gravitino/pull/9939#discussion_r2786838397
##########
common/src/main/java/org/apache/gravitino/Version.java:
##########
@@ -36,9 +36,10 @@ public class Version {
private static final int VERSION_PART_NUMBER = 3;
private static final Pattern PATTERN =
- Pattern.compile("^(\\d+)\\.(\\d+)\\.(\\d+)(?:-.*|\\.([a-zA-Z].*))?$");
+
Pattern.compile("^(\\d+)\\.(\\d+)\\.(\\d+)(?:rc(\\d{1,4})|-.*|\\.([a-zA-Z].*))?$");
private static final Version INSTANCE = new Version();
+ private static final int MAX_RC_NUMBER = 1000;
Review Comment:
Why do we need the magic number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
