Copilot commented on code in PR #9959:
URL: https://github.com/apache/gravitino/pull/9959#discussion_r2792313375
##########
web-v2/web/src/components/Icons.js:
##########
@@ -45,6 +45,34 @@ const Icons = {
</g>
</svg>
),
+ clickhouse: props => (
+ <svg
+ {...props}
+ class='icon'
Review Comment:
`Icons.clickhouse` sets `class='icon'` on the `<svg>` after spreading
`props`. In JSX this should be `className`, and as written it also prevents the
caller-provided `className` (e.g. `size-4`) from applying, so the icon
sizing/styling will be wrong. Use `className` and merge it with
`props.className` (or remove the hardcoded class entirely).
```suggestion
clickhouse: ({ className, ...props }) => (
<svg
{...props}
className={['icon', className].filter(Boolean).join(' ')}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
