jerryshao commented on code in PR #9944: URL: https://github.com/apache/gravitino/pull/9944#discussion_r2796581041
########## clients/client-python/gravitino/dto/requests/function_register_request.py: ########## @@ -0,0 +1,106 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from dataclasses import dataclass, field +from typing import List, Optional + +from dataclasses_json import config + +from gravitino.api.function.function_type import FunctionType +from gravitino.dto.function.function_definition_dto import FunctionDefinitionDTO +from gravitino.exceptions.base import IllegalArgumentException +from gravitino.rest.rest_message import RESTRequest + + +def _encode_function_type(func_type: FunctionType) -> str: Review Comment: This method seems existed in a different file, can you remove the duplication? ########## clients/client-python/gravitino/dto/requests/function_register_request.py: ########## @@ -0,0 +1,106 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from dataclasses import dataclass, field +from typing import List, Optional + +from dataclasses_json import config + +from gravitino.api.function.function_type import FunctionType +from gravitino.dto.function.function_definition_dto import FunctionDefinitionDTO +from gravitino.exceptions.base import IllegalArgumentException +from gravitino.rest.rest_message import RESTRequest + + +def _encode_function_type(func_type: FunctionType) -> str: + """Encode FunctionType to string.""" + if func_type is None: + return None + return func_type.value + + +def _decode_function_type(func_type_str: str) -> FunctionType: Review Comment: Also here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
