yuqi1129 commented on code in PR #9953:
URL: https://github.com/apache/gravitino/pull/9953#discussion_r2797741030
##########
trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/trino-435-445.patch:
##########
@@ -0,0 +1,97 @@
+diff --git
b/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/jdbc-mysql/00004_query_pushdown.txt
a/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/jdbc-mysql/00004_query_pushdown.txt
Review Comment:
What is this file used for?
##########
trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/jdbc-mysql/00004_query_pushdown.txt:
##########
@@ -12,35 +12,32 @@ INSERT: 15000 rows
"Trino version: %
%
- └─ TableScan[table = gt_mysql:gt_db1.customer->gt_db1.customer
gt_db1.customer limit=10 columns=[custkey:bigint:BIGINT]]
+ %TableScan[table = gt_mysql:gt_db1.customer->gt_db1.customer
gt_db1.customer limit=10 columns=[custkey:bigint:BIGINT]]
Layout: [custkey:bigint]
%
"
"Trino version: %
%
- └─ ScanFilter[table = gt_mysql:gt_db1.customer->gt_db1.customer
gt_db1.customer, filterPredicate = ""$like""(""phone"",
""$literal$""(from_base64('DgAAAFZBUklBQkxFX1dJRFRIAQAAAAEAAAALAAAAAAsAAAAGAAAAJTIzNDIlAA==')))]
- Layout: [custkey:bigint, name:varchar(25), address:varchar(40),
nationkey:bigint, phone:varchar(15), acctbal:decimal(12,2),
mktsegment:varchar(10), comment:varchar(117)]
+ %ScanFilter[table = gt_mysql:gt_db1.customer->gt_db1.customer
gt_db1.customer%like%phone%]
Review Comment:
Is this the query plan format for Trino 446？
##########
.github/workflows/python-integration-test.yml:
##########
@@ -77,7 +77,7 @@ jobs:
run: |
./gradlew compileDistribution -x test
- for pythonVersion in "3.9" "3.10" "3.11" "3.12"
+ for pythonVersion in "3.10" "3.11" "3.12"
Review Comment:
Do we plan to only support `3.10` or higher?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
