agnes-xinyi-lu commented on code in PR #9955:
URL: https://github.com/apache/gravitino/pull/9955#discussion_r2799716989


##########
iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergTableOperations.java:
##########
@@ -694,6 +695,40 @@ void testRemoteSigningNotSupported(Namespace namespace) {
         "Error message should mention remote signing: " + errorBody);
   }
 
+  @ParameterizedTest
+  
@MethodSource("org.apache.gravitino.iceberg.service.rest.IcebergRestTestUtil#testNamespaces")

Review Comment:
   @roryqi I don't think so. I think it's a misunderstanding. I'm not adding a 
test cache, I'm just adding a test, and I'm not using a weird parameter, every 
other test in this class uses this parameter, `testNamespaces` is just a const 
list with two namespace names for the test to use to verify it works in the 
path. I was just about to explain what @FANNG1 just said, this is out of scope, 
I'm not creating any new pattern here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to