roryqi commented on code in PR #10000:
URL: https://github.com/apache/gravitino/pull/10000#discussion_r2803678396
##########
core/src/main/java/org/apache/gravitino/cache/ReverseIndexRules.java:
##########
@@ -117,15 +117,23 @@ public class ReverseIndexRules {
// the values are policies/tags.
public static final ReverseIndexCache.ReverseIndexRule
GENERIC_METADATA_OBJECT_REVERSE_RULE =
(entity, key, reverseIndexCache) -> {
- // Name in GenericEntity contains no metalake.
GenericEntity genericEntity = (GenericEntity) entity;
EntityType type = entity.type();
if (genericEntity.name() != null) {
- String[] levels = genericEntity.name().split("\\.");
- String metalakeName = key.identifier().namespace().levels()[0];
- NameIdentifier objectNameIdentifier =
- NameIdentifier.of(ArrayUtils.addFirst(levels, metalakeName));
- reverseIndexCache.put(objectNameIdentifier, type, key);
+ // For entities with a non-empty namespace (e.g., views), use the
full identifier directly
Review Comment:
You can see TagManger
```
private static final Set<MetadataObject.Type>
SUPPORTED_METADATA_OBJECT_TYPES_FOR_TAGS =
Sets.newHashSet(
MetadataObject.Type.CATALOG,
MetadataObject.Type.SCHEMA,
MetadataObject.Type.TABLE,
MetadataObject.Type.FILESET,
MetadataObject.Type.TOPIC,
MetadataObject.Type.COLUMN,
MetadataObject.Type.MODEL);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
