mchades commented on code in PR #9580:
URL: https://github.com/apache/gravitino/pull/9580#discussion_r2810738516


##########
spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/iceberg/GravitinoIcebergCatalog.java:
##########
@@ -190,6 +194,17 @@ public org.apache.spark.sql.connector.catalog.Table 
loadTable(Identifier ident,
     }
   }
 
+  private boolean isIcebergFunctionNamespace(String[] namespace) {
+    try {
+      return namespace.length == 0 || isSystemNamespace(namespace);
+    } catch (IllegalAccessException
+        | InvocationTargetException
+        | NoSuchMethodException
+        | ClassNotFoundException e) {
+      throw new RuntimeException("Failed to check Iceberg function namespace", 
e);

Review Comment:
   Thank you for pointing this out. This is a nice-to-have fix—would you be 
interested in submitting a PR to address it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to