roryqi commented on code in PR #9988: URL: https://github.com/apache/gravitino/pull/9988#discussion_r2820635965
########## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergViewOperations.java: ########## @@ -131,10 +161,17 @@ public Response createView( @Produces(MediaType.APPLICATION_JSON) @Timed(name = "load-view." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) @ResponseMetered(name = "load-view", absolute = true) + @AuthorizationExpression( + expression = + "ANY(OWNER, METALAKE, CATALOG) || " + + "SCHEMA_OWNER_WITH_USE_CATALOG || " + + "ANY_USE_CATALOG && ANY_USE_SCHEMA && (VIEW::OWNER || ANY_SELECT_VIEW)", Review Comment: Do we need create privilege here? ########## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergViewOperations.java: ########## @@ -131,10 +161,17 @@ public Response createView( @Produces(MediaType.APPLICATION_JSON) @Timed(name = "load-view." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) @ResponseMetered(name = "load-view", absolute = true) + @AuthorizationExpression( + expression = + "ANY(OWNER, METALAKE, CATALOG) || " + + "SCHEMA_OWNER_WITH_USE_CATALOG || " + + "ANY_USE_CATALOG && ANY_USE_SCHEMA && (VIEW::OWNER || ANY_SELECT_VIEW)", Review Comment: Do we need `create view` privilege here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
