yuqi1129 commented on code in PR #9927:
URL: https://github.com/apache/gravitino/pull/9927#discussion_r2815800024
##########
gradle.properties:
##########
@@ -40,3 +40,4 @@ skipDockerTests = true
# enableFuse is used to enable the fuse module in the build.
enableFuse = false
+org.gradle.jvmargs=-Dpython.executable=/usr/bin/python3
Review Comment:
Why do we need to add this line?
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/operations/ClickHouseTableOperations.java:
##########
@@ -103,7 +103,8 @@ protected List<Index> getIndexes(Connection connection,
String databaseName, Str
String indexName = resultSet.getString("PK_NAME");
String columnName = resultSet.getString("COLUMN_NAME");
indexes.add(
- Indexes.of(Index.IndexType.PRIMARY_KEY, indexName, new String[][]
{{columnName}}));
+ Indexes.of(
Review Comment:
There seems to be no need to change all tests since you have added
compatible methods in `Indexes`.
##########
api/src/main/java/org/apache/gravitino/rel/indexes/Index.java:
##########
@@ -44,6 +45,11 @@ public interface Index {
*/
String[][] fieldNames();
+ /**
+ * @return Extra properties for index configuration
+ */
+ Map<String, String> properties();
Review Comment:
Has this comment been resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
