Copilot commented on code in PR #10144:
URL: https://github.com/apache/gravitino/pull/10144#discussion_r2876350576
##########
dev/release/release-build.sh:
##########
@@ -254,12 +254,15 @@ if [[ "$1" == "package" ]]; then
--detach-sig gravitino-lance-rest-server-$GRAVITINO_VERSION-bin.tar.gz
shasum -a 512 gravitino-lance-rest-server-$GRAVITINO_VERSION-bin.tar.gz >
gravitino-lance-rest-server-$GRAVITINO_VERSION-bin.tar.gz.sha512
- echo "Copying and signing Gravitino Trino connector binary distribution"
- cp
gravitino-$GRAVITINO_VERSION-bin/distribution/gravitino-trino-connector-$GRAVITINO_VERSION.tar.gz
.
- echo $GPG_PASSPHRASE | $GPG --passphrase-fd 0 --armour \
- --output gravitino-trino-connector-$GRAVITINO_VERSION.tar.gz.asc \
- --detach-sig gravitino-trino-connector-$GRAVITINO_VERSION.tar.gz
- shasum -a 512 gravitino-trino-connector-$GRAVITINO_VERSION.tar.gz >
gravitino-trino-connector-$GRAVITINO_VERSION.tar.gz.sha512
+ echo "Copying and signing Gravitino Trino connector binary distributions"
+ for trino_tar in
gravitino-$GRAVITINO_VERSION-bin/distribution/gravitino-trino-connector-*-$GRAVITINO_VERSION.tar.gz;
do
+ trino_connector_name=$(basename "$trino_tar" .tar.gz)
+ cp "$trino_tar" .
+ echo $GPG_PASSPHRASE | $GPG --passphrase-fd 0 --armour \
+ --output ${trino_connector_name}.tar.gz.asc \
Review Comment:
The glob in the `for trino_tar in ...gravitino-trino-connector-*...` loop
will expand to the literal pattern when there are no matches (default bash
behavior). With `set -e` this fails at `cp` with a confusing "cannot stat
...*..." error. Consider enabling `nullglob` for this loop and/or explicitly
checking for matches (e.g., via `compgen -G`) and exiting with a clear error
message if no Trino connector tarballs were produced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
