Copilot commented on code in PR #10156:
URL: https://github.com/apache/gravitino/pull/10156#discussion_r2878164832
##########
.github/workflows/backend-integration-test-action.yml:
##########
@@ -47,7 +52,7 @@ jobs:
- name: Package Gravitino
if: ${{ inputs.test-mode == 'deploy' }}
run: |
- ./gradlew compileDistribution -x test
+ ./gradlew compileDistribution -x test -x web-v2
Review Comment:
`./gradlew compileDistribution -x test -x web-v2` will fail because `-x`
expects a task path/name, and there is no Gradle task named `web-v2`. If the
intent is to skip building the web-v2 UI during packaging, exclude the actual
task(s) (e.g., the web-v2 build task) or remove this exclusion entirely.
```suggestion
./gradlew compileDistribution -x test
```
##########
.github/workflows/build.yml:
##########
@@ -143,7 +143,7 @@ jobs:
- name: Build with Gradle (skip mcp-server tests)
if: needs.changes.outputs.mcp_server_changes != 'true'
- run: ./gradlew build -PskipITs -PskipDockerTests=false -x
:clients:client-python:build -x :mcp-server:build -x :mcp-server:test -x
:mcp-server:pylint
+ run: ./gradlew build -PskipITs -PskipDockerTests=false -x
:clients:client-python:build -x :mcp-server:build -x :mcp-server:test -x
:mcp-server:pylint -x :web-v2:build -x :web-v2:test
Review Comment:
Excluding `-x :web-v2:build -x :web-v2:test` is unlikely to skip the
expensive web-v2 UI build, because the actual UI build task lives under the
`:web-v2:web` subproject (e.g., `:web-v2:web:build` in
`web-v2/web/build.gradle.kts`). If the goal is CI acceleration, exclude the
correct task path(s) so this change has the intended effect.
```suggestion
run: ./gradlew build -PskipITs -PskipDockerTests=false -x
:clients:client-python:build -x :mcp-server:build -x :mcp-server:test -x
:mcp-server:pylint -x :web-v2:web:build -x :web-v2:web:test
```
##########
.github/workflows/frontend-integration-test.yml:
##########
@@ -24,24 +24,32 @@ jobs:
- .github/**
- api/**
- bin/**
+ - authorizations/**
+ - bundler/**
- catalogs/**
- - clients/client-java/**
+ - catalogs-contrib/**
+ - clients/**
- common/**
- conf/**
- core/**
- dev/**
- gradle/**
- iceberg/**
- - integration-test-common/**
- - meta/**
+ - lance/**
+ - maintenance/**
- scripts/**
- - server/**
+ - server/**
Review Comment:
The paths-filter pattern `- server/** ` has a trailing space.
`dorny/paths-filter` treats these lines as literal glob patterns, so the extra
space can prevent matches and incorrectly skip the workflow. Remove the
trailing whitespace from the pattern.
```suggestion
- server/**
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
