jerryshao commented on code in PR #10190:
URL: https://github.com/apache/gravitino/pull/10190#discussion_r2882391691
##########
server/src/main/java/org/apache/gravitino/server/web/rest/StatisticOperations.java:
##########
@@ -476,6 +479,21 @@ static PartitionRange.BoundType getFromBoundType(boolean
inclusive) {
return inclusive ? PartitionRange.BoundType.CLOSED :
PartitionRange.BoundType.OPEN;
}
+ private static void validateStatisticsUpdateRequest(StatisticsUpdateRequest
request) {
+ if (request == null) {
+ throw new IllegalArgumentException(NULL_STATS_UPDATE_REQUEST_BODY_ERROR);
+ }
+ request.validate();
+ }
+
+ private static String getUpdatedStatisticNames(StatisticsUpdateRequest
request) {
+ if (request == null || request.getUpdates() == null) {
Review Comment:
`request.getUpdates() == null` is already checked here `request.validate()`.
You just removed this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
