diqiu50 commented on code in PR #10188:
URL: https://github.com/apache/gravitino/pull/10188#discussion_r2882420500
##########
trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/trino-469-478.patch:
##########
@@ -0,0 +1,384 @@
+diff --git
a/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/hive/catalog_hive_prepare.sql
b/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/hive/catalog_hive_prepare.sql
+index 67ea924ba..b392ae230 100644
+---
a/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/hive/catalog_hive_prepare.sql
++++
b/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/hive/catalog_hive_prepare.sql
+@@ -2,7 +2,7 @@ call gravitino.system.create_catalog(
+ 'gt_hive',
+ 'hive',
+ map(
+- array['metastore.uris', 'trino.bypass.fs.hadoop.enabled'],
+- array['${hive_uri}', 'true']
++ array['metastore.uris'],
++ array['${hive_uri}']
+ )
+ );
+\ No newline at end of file
+diff --git
a/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/jdbc-postgresql/00004_query_pushdown.txt
b/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/jdbc-postgresql/00004_query_pushdown.txt
+index edd8257ad..c4f271add 100644
+---
a/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/jdbc-postgresql/00004_query_pushdown.txt
++++
b/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/jdbc-postgresql/00004_query_pushdown.txt
+@@ -12,26 +12,26 @@ INSERT: 15000 rows
+
+ "Trino version: %
+ %
+- └─ TableScan[table = gt_postgresql:gt_db1.customer->gt_db1.customer
gt_db.gt_db1.customer limit=10 columns=[custkey:bigint:int8]]
++ %TableScan[table = gt_postgresql:gt_db1.customer->gt_db1.customer
gt_db1.customer limit=10 columns=[custkey:bigint:int8]]
+ Layout: [custkey:bigint]
+ %
+ "
+
+ "Trino version: %
+ %
+- └─ TableScan[table = gt_postgresql:gt_db1.customer->gt_db1.customer
gt_db.gt_db1.customer%constraints=%phone%LIKE%]
++ %TableScan[table = gt_postgresql:gt_db1.customer->gt_db1.customer
gt_db1.customer%constraints=%phone%LIKE%]
+ %
+ "
+
+ "Trino version: %
+ %
+- └─ TableScan[table = gt_postgresql:gt_db1.orders->Query[SELECT
sum(""totalprice"") AS ""_pfgnrtd_0"" FROM
""gt_db"".""gt_db1"".""orders""]%columns=[_pfgnrtd_0:decimal(38,2):decimal]]
++ %TableScan[table = gt_postgresql:gt_db1.orders->Query[SELECT
sum(""totalprice"") AS ""_pfgnrtd_0"" FROM
""gt_db1"".""orders""]%columns=[_pfgnrtd_0:decimal(38,2):decimal]]
+ %
+ "
+
+ "Trino version: %
+ %
+- └─ TableScan[table = gt_postgresql:gt_db1.%->Query[SELECT ""orderdate"",
sum(""totalprice"") AS ""_pfgnrtd_0"" FROM ""gt_db"".""gt_db1"".""orders""
GROUP BY ""orderdate""]%sortOrder=[orderdate:date:date ASC NULLS
LAST]%limit=10%columns=[orderdate:date:date, _pfgnrtd_0:decimal(38,2):decimal]]
++ %TableScan[table = gt_postgresql:gt_db1.%->Query[SELECT ""orderdate"",
sum(""totalprice"") AS ""_pfgnrtd_0"" FROM ""gt_db1"".""orders"" GROUP BY
""orderdate""]%sortOrder=[orderdate:date:date ASC NULLS
LAST]%limit=10%columns=[orderdate:date:date, _pfgnrtd_0:decimal(38,2):decimal]]
+ %
+ "
+
+diff --git
a/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/lakehouse-iceberg/catalog_iceberg_prepare.sql
b/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/lakehouse-iceberg/catalog_iceberg_prepare.sql
+index e310c051d..46ad6a38c 100644
+---
a/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/lakehouse-iceberg/catalog_iceberg_prepare.sql
++++
b/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/lakehouse-iceberg/catalog_iceberg_prepare.sql
+@@ -2,8 +2,8 @@ call gravitino.system.create_catalog(
+ 'gt_iceberg',
+ 'lakehouse-iceberg',
+ map(
+- array['uri', 'catalog-backend', 'warehouse',
'trino.bypass.fs.hadoop.enabled'],
+- array['${hive_uri}', 'hive',
'${hdfs_uri}/user/iceberg/warehouse/TrinoQueryIT', 'true']
++ array['uri', 'catalog-backend', 'warehouse'],
++ array['${hive_uri}', 'hive',
'${hdfs_uri}/user/iceberg/warehouse/TrinoQueryIT']
+ )
+ );
+
+diff --git
a/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/tpcds/00002.sql
b/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/tpcds/00002.sql
+index 7ed8fbf18..0e797b639 100644
+---
a/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/tpcds/00002.sql
++++
b/trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/tpcds/00002.sql
+@@ -36,13 +36,13 @@ UNION ALL (
+ )
+ SELECT
+ "d_week_seq1"
+-, CAST(("sun_sales1" / "sun_sales2") as DECIMAL(38,2))
+-, CAST(("mon_sales1" / "mon_sales2") as DECIMAL(38,2))
+-, CAST(("tue_sales1" / "tue_sales2") as DECIMAL(38,2))
+-, CAST(("wed_sales1" / "wed_sales2") as DECIMAL(38,2))
+-, CAST(("thu_sales1" / "thu_sales2") as DECIMAL(38,2))
+-, CAST(("fri_sales1" / "fri_sales2") as DECIMAL(38,2))
+-, CAST(("sat_sales1" / "sat_sales2") as DECIMAL(38,2))
++, "round"(("sun_sales1" / "sun_sales2"), 2)
++, "round"(("mon_sales1" / "mon_sales2"), 2)
++, "round"(("tue_sales1" / "tue_sales2"), 2)
++, "round"(("wed_sales1" / "wed_sales2"), 2)
++, "round"(("thu_sales1" / "thu_sales2"), 2)
++, "round"(("fri_sales1" / "fri_sales2"), 2)
++, "round"(("sat_sales1" / "sat_sales2"), 2)
Review Comment:
Handle it in the next pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
