roryqi commented on code in PR #10180:
URL: https://github.com/apache/gravitino/pull/10180#discussion_r2883232060


##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/IcebergCatalogWrapperManager.java:
##########
@@ -56,7 +56,7 @@ public IcebergCatalogWrapperManager(
     this.configProvider = configProvider;
     this.catalogWrapperCache =
         Caffeine.newBuilder()
-            .expireAfterWrite(
+            .expireAfterAccess(

Review Comment:
   If a catalog is changed in the another server, the catalog won't be updated 
in this server if the catalog is always accessed.
   
   Catalog A in the server 1 is cached.
   Catalog A in the server 2 is changed.
   Catalog A in the server 1 is accessed in every 10 minutes. The Catalog A is 
expired in 1 hour. The catalog A won't be changed. We will read the legacy 
catalog A in the server 1.
   
   If we don't change it, we can access the new data after 1 hour.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to