Copilot commented on code in PR #10202:
URL: https://github.com/apache/gravitino/pull/10202#discussion_r2883350677
##########
.github/workflows/backend-integration-test-action.yml:
##########
@@ -47,7 +52,7 @@ jobs:
- name: Package Gravitino
if: ${{ inputs.test-mode == 'deploy' }}
run: |
- ./gradlew compileDistribution -x test
+ ./gradlew compileDistribution -x test -x web-v2:web:build
Review Comment:
`compileDistribution` depends on `:web-v2:web:build` and copies the `web-v2`
WAR into `distribution/package` (see root `build.gradle.kts` task definition).
Excluding `:web-v2:web:build` here is likely to make `compileDistribution` fail
due to the missing WAR, breaking deploy-mode backend ITs. Remove this
exclusion, or change the Gradle packaging logic to not require the web-v2
artifact when running backend ITs.
```suggestion
./gradlew compileDistribution -x test
```
##########
.github/workflows/frontend-integration-test.yml:
##########
@@ -24,24 +24,32 @@ jobs:
- .github/**
- api/**
- bin/**
+ - authorizations/**
+ - bundles/**
- catalogs/**
- - clients/client-java/**
+ - catalogs-contrib/**
+ - clients/**
- common/**
- conf/**
- core/**
- dev/**
- gradle/**
- iceberg/**
- - integration-test-common/**
- - meta/**
+ - lance/**
- scripts/**
- - server/**
+ - server/**
Review Comment:
There is a trailing space after `server/**` in the paths-filter list.
`dorny/paths-filter` patterns are treated as literal strings, so the extra
space can prevent matching server changes and incorrectly skip the workflow.
Remove the trailing whitespace so the pattern is exactly `server/**`.
```suggestion
- server/**
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
