FANNG1 commented on code in PR #10191: URL: https://github.com/apache/gravitino/pull/10191#discussion_r2883402674
########## maintenance/optimizer/src/test/java/org/apache/gravitino/maintenance/optimizer/integration/test/RecommenderIT.java: ########## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.maintenance.optimizer.integration.test; + +import com.google.common.collect.ImmutableMap; +import java.util.Arrays; +import java.util.List; +import java.util.Map; +import java.util.UUID; +import java.util.function.Function; +import java.util.stream.Collectors; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.maintenance.optimizer.api.common.PartitionEntry; +import org.apache.gravitino.maintenance.optimizer.api.common.PartitionPath; +import org.apache.gravitino.maintenance.optimizer.api.recommender.JobExecutionContext; +import org.apache.gravitino.maintenance.optimizer.api.updater.StatisticsUpdater; +import org.apache.gravitino.maintenance.optimizer.common.PartitionEntryImpl; +import org.apache.gravitino.maintenance.optimizer.common.StatisticEntryImpl; +import org.apache.gravitino.maintenance.optimizer.common.conf.OptimizerConfig; +import org.apache.gravitino.maintenance.optimizer.recommender.Recommender; +import org.apache.gravitino.maintenance.optimizer.recommender.handler.compaction.CompactionJobContext; +import org.apache.gravitino.maintenance.optimizer.recommender.handler.compaction.CompactionStrategyHandler; +import org.apache.gravitino.maintenance.optimizer.recommender.util.StrategyUtils; +import org.apache.gravitino.maintenance.optimizer.updater.statistics.GravitinoStatisticsUpdater; +import org.apache.gravitino.stats.StatisticValues; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; + +/* + * 1. update table stats + * 2. add policy + * 3. run recommender to get optimize result + */ +public class RecommenderIT extends GravitinoOptimizerEnvIT { + + private static final String STATISTICS_PREFIX = "custom-"; + private static final String DATAFILE_MSE = STATISTICS_PREFIX + "datafile_size_mse"; + private static final String DELETE_FILE_NUM = STATISTICS_PREFIX + "position_delete_file_number"; + private static final String SESSION_ID = "recommender-it-" + UUID.randomUUID(); + + private StatisticsUpdater statisticsUpdater; + + @Override + protected Map<String, String> getSpecifyConfigs() { + return Map.of( + OptimizerConfig.OPTIMIZER_PREFIX + + "strategyHandler." + + CompactionStrategyHandler.NAME + + ".className", + CompactionStrategyHandler.class.getName(), + OptimizerConfig.JOB_SUBMITTER_CONFIG.getKey(), + RecordingJobSubmitterForIT.NAME, + RecordingJobSubmitterForIT.SESSION_ID_KEY, + SESSION_ID); + } + + @BeforeAll + void init() { + this.statisticsUpdater = new GravitinoStatisticsUpdater(); + statisticsUpdater.initialize(optimizerEnv); + } Review Comment: update ########## maintenance/optimizer/src/test/java/org/apache/gravitino/maintenance/optimizer/integration/test/GravitinoStrategyIT.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.maintenance.optimizer.integration.test; + +import com.google.common.collect.ImmutableMap; +import java.util.List; +import org.apache.gravitino.maintenance.optimizer.api.common.Strategy; +import org.apache.gravitino.maintenance.optimizer.recommender.strategy.GravitinoStrategyProvider; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; + +public class GravitinoStrategyIT extends GravitinoOptimizerEnvIT { + + private GravitinoStrategyProvider strategyProvider; + + @BeforeAll + void init() { + this.strategyProvider = new GravitinoStrategyProvider(); + strategyProvider.initialize(optimizerEnv); + } Review Comment: updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
