diqiu50 commented on code in PR #10194:
URL: https://github.com/apache/gravitino/pull/10194#discussion_r2887429190
##########
spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/catalog/BaseCatalog.java:
##########
@@ -498,6 +514,20 @@ public UnboundFunction loadFunction(Identifier ident)
throws NoSuchFunctionExcep
throw new NoSuchFunctionException(ident);
}
+ protected Table loadTableForWriting(Identifier ident) throws
NoSuchTableException {
+ org.apache.gravitino.rel.Table gravitinoTable =
loadGravitinoTableForWriting(ident);
+ org.apache.spark.sql.connector.catalog.Table sparkTable =
loadSparkTable(ident);
+ // Will create a catalog specific table
+ return createSparkTable(
+ ident,
+ gravitinoTable,
+ sparkTable,
+ sparkCatalog,
+ propertiesConverter,
+ sparkTransformConverter,
+ sparkTypeConverter);
+ }
+
Review Comment:
Do we need to add this exception type to the function signature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
