Copilot commented on code in PR #10239: URL: https://github.com/apache/gravitino/pull/10239#discussion_r2888309900
########## docs/how-to-use-gvfs.md: ########## @@ -401,8 +401,8 @@ FileSystem fs = filesetPath.getFileSystem(conf); + A Hadoop environment with HDFS or other Hadoop Compatible File System (HCFS) implementations like S3, GCS, etc. GVFS has been tested against Hadoop 3.3.1. It is recommended to use Hadoop 3.3.1 or later, but it should work with Hadoop 2.x. Please create an [issue](https://www.github.com/apache/gravitino/issues) if you find any compatibility issues. -+ Python version >= 3.9. It has been tested GVFS works well with Python 3.9. - Your Python version should be at least higher than Python 3.9. ++ Python version >= 3.12. It has been tested GVFS works well with Python 3.12. + Your Python version should be at least Python 3.12. Review Comment: The stated GVFS Python prerequisite "Python version >= 3.12" appears inconsistent with the Gravitino Python client package metadata (clients/client-python/setup.py sets python_requires to ">=3.10" and classifiers include 3.10-3.12). Please align this doc requirement with the actual supported minimum version, or update the package metadata if GVFS truly requires 3.12+. ```suggestion + Python version >= 3.10. GVFS has been tested to work well with Python versions 3.10–3.12. Your Python version should be at least Python 3.10. ``` ########## docs/how-to-build.md: ########## @@ -13,7 +13,7 @@ license: "This software is licensed under the Apache License version 2." + Linux or macOS operating system + Git + A Java Development Kit, version 17, installed in your environment to launch Gradle -+ Python 3.9, 3.10, 3.11, or 3.12 to build the Gravitino Python client ++ Python 3.10, 3.11, or 3.12 to build the Gravitino Python client. Review Comment: There is trailing whitespace at the end of this prerequisite bullet, and this is the only prerequisite line ending with a period. Consider removing the trailing space and keeping punctuation consistent across the list items. ```suggestion + Python 3.10, 3.11, or 3.12 to build the Gravitino Python client ``` ########## docs/how-to-use-gvfs.md: ########## @@ -401,8 +401,8 @@ FileSystem fs = filesetPath.getFileSystem(conf); + A Hadoop environment with HDFS or other Hadoop Compatible File System (HCFS) implementations like S3, GCS, etc. GVFS has been tested against Hadoop 3.3.1. It is recommended to use Hadoop 3.3.1 or later, but it should work with Hadoop 2.x. Please create an [issue](https://www.github.com/apache/gravitino/issues) if you find any compatibility issues. -+ Python version >= 3.9. It has been tested GVFS works well with Python 3.9. - Your Python version should be at least higher than Python 3.9. ++ Python version >= 3.12. It has been tested GVFS works well with Python 3.12. Review Comment: Grammar: "It has been tested GVFS works well..." is missing a connector (e.g., "It has been tested that GVFS works well..."). ```suggestion + Python version >= 3.12. GVFS has been tested to work well with Python 3.12. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
