jerryshao commented on code in PR #10106:
URL: https://github.com/apache/gravitino/pull/10106#discussion_r2889399644


##########
clients/client-java/build.gradle.kts:
##########
@@ -16,12 +16,27 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+import org.gradle.api.attributes.java.TargetJvmVersion
+import org.gradle.api.tasks.compile.JavaCompile
+

Review Comment:
   This adds Java 17 test compilation targets to `client-java` (which likely 
targets a lower Java version for its main sources). Please add a comment 
explaining why this is needed — presumably it is a workaround for transitive 
classpath conflicts introduced by the new `gravitino-updaters` / Spark test 
dependencies. Without context, this change looks like an unrelated side-effect.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to