ajw711 commented on PR #10257: URL: https://github.com/apache/gravitino/pull/10257#issuecomment-4009850942
Thanks for the thorough review, @jerryshao! I've addressed all your feedback: 1. **Code Comment**: Added a comment in `BuiltInJobTemplateEventListener.java` explaining that `existing.name()` is preferred as a defensive measure — if a built-in template is renamed between Gravitino versions, using `newTemplate.name()` could cause a `NoSuchEntityException`. Linked to #10176. 2. **Realistic Test Scenario**: Updated the test to use the same name for both the map key and the template (`builtin-existing`), which matches the actual production code path. 3. **Explicit Assertions**: Added `Assertions.assertDoesNotThrow()` to document intent, and an `entityStore.get()` check to verify the entity was actually updated (version `v1` → `v2`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
