pythaac opened a new pull request, #10301:
URL: https://github.com/apache/gravitino/pull/10301
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
In `purgeTable()`, when `store.delete()` throws `NoSuchEntityException` for
unmanaged table:
- Before this change, it returns `false`
- After this change, it returns the catalog result (`droppedFromCatalog`)
### Why are the changes needed?
The previous behavior contradicts the method’s own comment that store
deletion outcome should not affect the returned result, and only the catalog
result should be used.
Fix: #10274
### Does this PR introduce _any_ user-facing change?
`dropped` for DELETE
/metalakes/{metalake}/catalogs/{catalog}/schemas/{schema}/tables/{table}?purge=true:
- Before this change, it is always `false`
- After this change, it is the catalog result (`droppedFromCatalog`)
### How was this patch tested?
Verify that `purgeTable()` returns true when "droppedFromCatalog" is true in
NoSuchEntityException for unmanaged table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
