yuqi1129 opened a new pull request, #10314:
URL: https://github.com/apache/gravitino/pull/10314
### What changes were proposed in this pull request?
This PR fixes JDBC catalog property visibility for connection pool sizing.
- Marks and as non-hidden in .
- Adds regression tests in :
-
-
### Why are the changes needed?
returns catalog properties via , which filters hidden properties. Since
and were incorrectly marked hidden, they disappeared when loading catalog
properties after creation.
Fix: #10284
### Does this PR introduce _any_ user-facing change?
Yes.
Users who set / during JDBC catalog creation can now see them in loaded
catalog properties as expected.
### How was this patch tested?
Ran:
To honour the JVM settings for this build a single-use Daemon process will
be forked. For more on this, please refer to
https://docs.gradle.org/8.2/userguide/gradle_daemon.html#sec:disabling_the_daemon
in the Gradle documentation.
Daemon will be stopped at the end of the build
Skipping filesystem-fuse module since enableFuse is set to false
> Configure project :
checkContainerRunning failed: Process 'command 'bash'' finished with
non-zero exit value 1
Current docker context is: orbstack
------------------ Check Docker environment ---------------------
Docker server status ............................................ [running]
mac-docker-connector status .....................................
[[31mstop[0m]
OrbStack status ................................................. [yes]
Using Docker container to run all tests ......................... [embedded
test]
-----------------------------------------------------------------
> Configure project :bundles
null
> Configure project :core
Kotlin DSL property assignment is an incubating feature.
> Task :catalogs:catalog-jdbc-common:processResources NO-SOURCE
> Task :spotlessInternalRegisterDependencies UP-TO-DATE
> Task :catalogs:catalog-common:processResources NO-SOURCE
> Task :api:processResources UP-TO-DATE
> Task :core:processResources UP-TO-DATE
> Task :common:processResources
> Task :catalogs:catalog-common:spotlessJava UP-TO-DATE
> Task :catalogs:catalog-common:spotlessJavaCheck UP-TO-DATE
> Task :catalogs:catalog-common:spotlessKotlinGradle UP-TO-DATE
> Task :catalogs:catalog-common:spotlessKotlinGradleCheck UP-TO-DATE
> Task :catalogs:catalog-common:spotlessCheck UP-TO-DATE
> Task :catalogs:catalog-jdbc-common:spotlessJava UP-TO-DATE
> Task :catalogs:catalog-jdbc-common:spotlessJavaCheck UP-TO-DATE
> Task :catalogs:catalog-jdbc-common:spotlessKotlinGradle UP-TO-DATE
> Task :catalogs:catalog-jdbc-common:spotlessKotlinGradleCheck UP-TO-DATE
> Task :catalogs:catalog-jdbc-common:spotlessCheck UP-TO-DATE
> Task :catalogs:catalog-jdbc-common:processTestResources UP-TO-DATE
> Task :common:spotlessJava UP-TO-DATE
> Task :common:spotlessJavaCheck UP-TO-DATE
> Task :api:spotlessJava UP-TO-DATE
> Task :common:spotlessKotlinGradle UP-TO-DATE
> Task :api:spotlessJavaCheck UP-TO-DATE
> Task :common:spotlessKotlinGradleCheck UP-TO-DATE
> Task :common:spotlessCheck UP-TO-DATE
> Task :api:spotlessKotlinGradle UP-TO-DATE
> Task :api:spotlessKotlinGradleCheck UP-TO-DATE
> Task :api:spotlessCheck UP-TO-DATE
> Task :api:compileJava UP-TO-DATE
> Task :api:classes UP-TO-DATE
> Task :api:jar UP-TO-DATE
> Task :common:compileJava UP-TO-DATE
> Task :common:classes
> Task :core:spotlessJava UP-TO-DATE
> Task :core:spotlessJavaCheck UP-TO-DATE
> Task :core:spotlessKotlinGradle UP-TO-DATE
> Task :core:spotlessKotlinGradleCheck UP-TO-DATE
> Task :core:spotlessCheck UP-TO-DATE
> Task :common:jar
> Task :catalogs:catalog-common:compileJava UP-TO-DATE
> Task :catalogs:catalog-common:classes UP-TO-DATE
> Task :catalogs:catalog-common:jar UP-TO-DATE
> Task :core:compileJava UP-TO-DATE
> Task :core:classes UP-TO-DATE
> Task :core:jar UP-TO-DATE
> Task :catalogs:catalog-jdbc-common:compileJava UP-TO-DATE
> Task :catalogs:catalog-jdbc-common:classes UP-TO-DATE
> Task :catalogs:catalog-jdbc-common:compileTestJava UP-TO-DATE
> Task :catalogs:catalog-jdbc-common:testClasses UP-TO-DATE
> Task :catalogs:catalog-jdbc-common:test
[TEST-TIMING] START module=:catalogs:catalog-jdbc-common
task=:catalogs:catalog-jdbc-common:test at=1773056250812
[TEST-TIMING] END module=:catalogs:catalog-jdbc-common
task=:catalogs:catalog-jdbc-common:test startMs=1773056250812
endMs=1773056257404 durationMs=6592
> Task :catalogs:catalog-jdbc-common:jacocoTestReport
Deprecated Gradle features were used in this build, making it incompatible
with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings
and determine if they come from your own scripts or plugins.
For more on this, please refer to
https://docs.gradle.org/8.2/userguide/command_line_interface.html#sec:command_line_warnings
in the Gradle documentation.
BUILD SUCCESSFUL in 43s
37 actionable tasks: 4 executed, 33 up-to-date
The new regression test verifies pool size properties remain available after
create/load behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
