yuqi1129 commented on code in PR #10384:
URL: https://github.com/apache/gravitino/pull/10384#discussion_r2922580894
##########
catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/storage/PaimonOSSFileSystemConfig.java:
##########
@@ -63,6 +64,14 @@ public PaimonOSSFileSystemConfig(Map<String, String>
properties) {
.checkValue(StringUtils::isNotBlank,
ConfigConstants.NOT_BLANK_ERROR_MSG)
.create();
+ public static final ConfigEntry<String> PAIMON_OSS_IMPLEMENTATION_ENTRY =
+ new ConfigBuilder(OSS_IMPLEMENTATION)
+ .doc("The filesystem implementation of the Aliyun oss")
Review Comment:
It's advised to use `OSS` instead of `oss`.
Besides, you may also need to update the related document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
