FANNG1 commented on PR #10442: URL: https://github.com/apache/gravitino/pull/10442#issuecomment-4067498279
@jerryshao Thanks, these points are reasonable. I updated the spec locally in follow-up commit `1bb0952b5` to address them explicitly: - added a concrete project migration rule for replacing `:flink-connector:flink` / `:flink-connector:flink-runtime` with `flink-common`, `flink-1.18`, and `flink-runtime-1.18`, and stated that the old `settings.gradle.kts` entries should be removed - added a provider placement matrix plus explicit `1.19` / `1.20` runtime linkage validation requirements, and a separate `Risk 6` for provider-level ABI drift across `1.18` to `1.20` - clarified the `META-INF/services` rule so that a versioned module service file replaces the effective factory list for that variant and must re-list all valid factories - stated explicitly that `flink-common:test` only validates the Flink `1.18` baseline dependency graph, and that `1.19` / `1.20` linkage-sensitive regressions belong in the versioned modules - added the smaller clarifications on artifact naming, why `flink-common` compiles against `1.18` instead of the latest Flink minor, and the `_2.12` scope for `1.18` / `1.19` / `1.20` I have not resolved or closed any existing comments. I will push the follow-up commit after the next confirmation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
