roryqi commented on code in PR #10451:
URL: https://github.com/apache/gravitino/pull/10451#discussion_r2945595458
##########
core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/base/JobMetaBaseSQLProvider.java:
##########
@@ -183,14 +183,21 @@ public String deleteJobMetasByLegacyTimeline(
+ " WHERE deleted_at < #{legacyTimeline} AND deleted_at > 0 LIMIT
#{limit}";
}
+ // Note: this method is currently not called by the service layer.
batchGetJobByIdentifier in
+ // JobMetaService uses batchSelectJobByRunIds instead, because jobs are
identified by their
+ // numeric run ID rather than a name. This method is kept correct and
consistent to avoid
+ // confusion if it is used in the future.
public String batchSelectJobByIdentifier(
Review Comment:
This method should be unused. We can remove it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
