Abyss-lord commented on code in PR #10393:
URL: https://github.com/apache/gravitino/pull/10393#discussion_r2972663436
##########
core/src/main/java/org/apache/gravitino/catalog/SchemaOperationDispatcher.java:
##########
@@ -274,6 +274,10 @@ public Schema alterSchema(NameIdentifier ident,
SchemaChange... changes)
.withId(schemaEntity.id())
.withName(schemaEntity.name())
.withNamespace(ident.namespace())
+ .withComment(alteredSchema.comment())
+ .withProperties(
Review Comment:
https://github.com/Lucas61000/gravitino/blob/02d1d373de5a6f876d394f0bab3cd93b93a697b3/core/src/main/java/org/apache/gravitino/catalog/SchemaOperationDispatcher.java#L150
IMHO, when creating a schema, we should also retrieve comments and
properties from external sources and then persist them.
Should we open an additional issue to fix this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
