Copilot commented on code in PR #10513: URL: https://github.com/apache/gravitino/pull/10513#discussion_r2973885390
########## docs/docker-image-details.md: ########## @@ -83,6 +86,9 @@ Use `GRAVITINO_MEM` to size the JVM (default `-Xms1024m -Xmx1024m -XX:MaxMetaspa Changelog +- apache/gravitino-iceberg-rest:1.1.1 + - Based on Gravitino 1.1.1, you can know more information from 1.1.1 [release notes](https://github.com/apache/gravitino/releases/tag/v1.1.1). Review Comment: Same wording issue here: “you can know more information from …” is ungrammatical. Please rephrase (e.g., “For more information, see the 1.1.1 release notes”) for clearer documentation. ```suggestion - Based on Gravitino 1.1.1. For more information, see 1.1.1 [release notes](https://github.com/apache/gravitino/releases/tag/v1.1.1). ``` ########## docs/docker-image-details.md: ########## @@ -23,6 +23,9 @@ JVM heap and metaspace are controlled by `GRAVITINO_MEM` (default `-Xms1024m -Xm Changelog +- apache/gravitino:1.1.1 + - Based on Gravitino 1.1.1, you can know more information from 1.1.1 [release notes](https://github.com/apache/gravitino/releases/tag/v1.1.1). + Review Comment: The sentence “you can know more information from …” is ungrammatical and reads awkwardly in docs. Consider rephrasing to something like “For more information, see the 1.1.1 release notes” (and optionally align with the wording used in other sections of this doc). ########## dev/release/release-build.sh: ########## @@ -210,8 +210,14 @@ if [[ "$1" == "package" ]]; then rm -f gravitino-$GRAVITINO_VERSION-src/NOTICE.rest rm -f gravitino-$GRAVITINO_VERSION-src/LICENSE.trino rm -f gravitino-$GRAVITINO_VERSION-src/NOTICE.trino + rm -f gravitino-$GRAVITINO_VERSION-src/LICENSE.iceberg + rm -f gravitino-$GRAVITINO_VERSION-src/NOTICE.iceberg + rm -f gravitino-$GRAVITINO_VERSION-src/LICENSE.lance + rm -f gravitino-$GRAVITINO_VERSION-src/NOTICE.lance rm -f gravitino-$GRAVITINO_VERSION-src/web/web/LICENSE.bin rm -f gravitino-$GRAVITINO_VERSION-src/web/web/NOTICE.bin + rm -f gravitino-$GRAVITINO_VERSION-src/web-v2/web/LICENSE.bin + rm -f gravitino-$GRAVITINO_VERSION-src/web-v2/web/NOTICE.bin Review Comment: This branch doesn’t appear to contain a `web-v2/` directory, so these cleanup lines will never remove anything and may confuse future maintainers. Consider removing them for branch-1.1, or guarding them with a directory existence check so the intent is explicit. ```suggestion if [[ -d gravitino-$GRAVITINO_VERSION-src/web-v2/web ]]; then rm -f gravitino-$GRAVITINO_VERSION-src/web-v2/web/LICENSE.bin rm -f gravitino-$GRAVITINO_VERSION-src/web-v2/web/NOTICE.bin fi ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
