roryqi commented on code in PR #10536:
URL: https://github.com/apache/gravitino/pull/10536#discussion_r2986273025
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java:
##########
@@ -288,7 +290,7 @@ public Response loadTable(
String namespace,
@IcebergAuthorizationMetadata(type = RequestType.LOAD_TABLE) @Encoded()
@PathParam("table")
String table,
- @DefaultValue("all") @QueryParam("snapshots") String snapshots,
+ @DefaultValue(DEFAULT_SNAPSHOTS) @QueryParam("snapshots") String
snapshots,
Review Comment:
Another point:
We can do it in the next pull request.
If the `snapshots` is `all`, we should return all the snapshots.
If the `snapshots` is `refs`, we should return all the snapshots is used in
the references.
We should get the refs by ` loadTableResponse.tableMetadata().refs()` and
only return the snapshots which existed in the `refs()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
