roryqi commented on PR #10589: URL: https://github.com/apache/gravitino/pull/10589#issuecomment-4159431501
> @roryqi Please review and let me know if any further action is needed. Thanks for your pull request 1. Could u add unit tests for this pull request? 2. Could u use `Maps.newHashMap()` instead of `Map.of`? `Map.of` can't be used in JDK8. Our client need to used for JDK8, although our server can only be used in JDK17. I still prefer keeping consistent style. 3. Could u modify the title `improvement(core): Eliminate N+1 queries in metadata object…`? You should remove `...`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
