sachinnn99 opened a new pull request, #10664:
URL: https://github.com/apache/gravitino/pull/10664
### What changes were proposed in this pull request?
Add `@Param("metalakeId")` annotation to
`softDeleteGroupRoleRelByMetalakeId` in the mapper, SQL provider factory, base
SQL provider, and PostgreSQL provider.
### Why are the changes needed?
`GroupRoleRelMapper.softDeleteGroupRoleRelByMetalakeId(Long metalakeId)` is
missing the `@Param("metalakeId")` annotation, unlike every other soft-delete
method in the same mapper. The SQL templates reference `#{metalakeId}`, so
without the annotation MyBatis relies on runtime-retained parameter names,
which is fragile and can cause binding failures during metalake deletion.
Fix: #10657
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing unit and integration tests cover the metalake deletion path that
invokes this mapper method. The change is additive — it makes the parameter
binding explicit rather than implicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
