roryqi commented on code in PR #10668:
URL: https://github.com/apache/gravitino/pull/10668#discussion_r3033773950


##########
server-common/src/main/java/org/apache/gravitino/server/web/JettyServer.java:
##########
@@ -466,10 +466,14 @@ public void addCustomFilters(String pathSpec) {
   }
 
   public void addSystemFilters(String pathSpec) {
+    addSystemFilters(pathSpec, new AuthenticationFilter());

Review Comment:
   I prefer add a protected method `createAuthenticationFilter`.
   IcebergREST can use the anonymous class to create it
   ```
   new JettyServer() {
      Filter createAuthentionFilter {
          return IcebergAuthenticationFilter();
      }
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to