sachinnn99 commented on code in PR #10699:
URL: https://github.com/apache/gravitino/pull/10699#discussion_r3049982332
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java:
##########
@@ -191,7 +204,7 @@ protected boolean useDifferentClassLoader() {
return false;
}
Review Comment:
Added JavaDoc explaining that the `protected` visibility is for subclasses
that synthesize a `LoadTableResponse` without delegating to `super` (test
wrappers around in-memory catalogs that can't perform certain operations
natively), so they can still apply the same vending and injection logic as
production paths.
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java:
##########
@@ -239,7 +252,7 @@ private Credential getCredential(
return credential;
}
Review Comment:
Same JavaDoc rationale added on `shouldGenerateCredential`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
