diqiu50 commented on code in PR #10706:
URL: https://github.com/apache/gravitino/pull/10706#discussion_r3061733295
##########
web-v2/integration-test/build.gradle.kts:
##########
@@ -67,6 +68,8 @@ tasks.test {
dependsOn(":catalogs:catalog-kafka:jar",
":catalogs:catalog-kafka:runtimeJars")
// Frontend tests depend on the web page, so we need to build the web
module first.
- dependsOn(":web-v2:web:build")
+ if (!skipWebWar) {
Review Comment:
Why not skip the entire web module? The comment above says the frontend
tests depend on the web build, but you only removed the build step.
##########
build.gradle.kts:
##########
@@ -775,28 +777,34 @@ tasks {
val outputDir = projectDir.dir("distribution")
val compileDistribution by registering {
- dependsOn(
- "copyCatalogLibAndConfigs",
- "copySubprojectDependencies",
- "copySubprojectLib",
- "copyCliLib",
- "copyJobsLib",
- ":authorizations:copyLibAndConfig",
- ":iceberg:iceberg-rest-server:copyLibAndConfigs",
- ":lance:lance-rest-server:copyLibAndConfigs",
- ":maintenance:optimizer:copyLibAndConfigs",
- ":web:web:build",
- ":web-v2:web:build"
- )
+ val dependencies =
+ mutableListOf(
+ "copyCatalogLibAndConfigs",
+ "copySubprojectDependencies",
+ "copySubprojectLib",
+ "copyCliLib",
+ "copyJobsLib",
+ ":authorizations:copyLibAndConfig",
+ ":iceberg:iceberg-rest-server:copyLibAndConfigs",
+ ":lance:lance-rest-server:copyLibAndConfigs",
+ ":maintenance:optimizer:copyLibAndConfigs"
+ )
+ if (!skipWebWar) {
+ dependencies.add(":web:web:build")
+ dependencies.add(":web-v2:web:build")
+ }
+ dependsOn(dependencies)
group = "gravitino distribution"
outputs.dir(projectDir.dir("distribution/package"))
doLast {
copy {
from(projectDir.dir("conf")) { into("package/conf") }
from(projectDir.dir("bin")) { into("package/bin") }
-
from(projectDir.dir("web/web/build/libs/${rootProject.name}-web-$version.war"))
{ into("package/web") }
-
from(projectDir.dir("web-v2/web/build/libs/${rootProject.name}-web-$version.war"))
{ into("package/web-v2") }
+ if (!skipWebWar) {
Review Comment:
Can we check whether this condition is really necessary? If the web module
has no build artifacts, copying it shouldn’t have any effect anyway, right?
##########
web/integration-test/build.gradle.kts:
##########
@@ -67,6 +68,8 @@ tasks.test {
dependsOn(":catalogs:catalog-kafka:jar",
":catalogs:catalog-kafka:runtimeJars")
// Frontend tests depend on the web page, so we need to build the web
module first.
- dependsOn(":web:web:build")
Review Comment:
Same issues
##########
web-v2/integration-test/build.gradle.kts:
##########
@@ -67,6 +68,8 @@ tasks.test {
dependsOn(":catalogs:catalog-kafka:jar",
":catalogs:catalog-kafka:runtimeJars")
// Frontend tests depend on the web page, so we need to build the web
module first.
- dependsOn(":web-v2:web:build")
+ if (!skipWebWar) {
Review Comment:
Why not introduce a skipWeb option to skip everything related to the web
module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
