Copilot commented on code in PR #10968: URL: https://github.com/apache/gravitino/pull/10968#discussion_r3192904674
########## authenticators/authenticator-basic/src/main/java/org/apache/gravitino/auth/local/password/Argon2idPasswordHasher.java: ########## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.auth.local.password; + +import com.google.common.base.Preconditions; +import java.nio.charset.StandardCharsets; +import java.security.MessageDigest; +import java.security.SecureRandom; +import java.util.Base64; +import org.apache.commons.lang3.StringUtils; +import org.bouncycastle.crypto.generators.Argon2BytesGenerator; +import org.bouncycastle.crypto.params.Argon2Parameters; +import org.bouncycastle.util.Arrays; + +/** Argon2id-based password hasher. */ +public class Argon2idPasswordHasher implements PasswordHasher { + + private static final String PHC_PREFIX = "$argon2id$"; + private static final SecureRandom SECURE_RANDOM = new SecureRandom(); + + @Override + public String hash(String plainPassword) { + Preconditions.checkArgument( + StringUtils.isNotBlank(plainPassword), "Plain password must not be blank"); + + byte[] salt = new byte[Argon2idDefaults.DEFAULT_SALT_LENGTH]; + SECURE_RANDOM.nextBytes(salt); + byte[] passwordBytes = plainPassword.getBytes(StandardCharsets.UTF_8); + byte[] hash = new byte[Argon2idDefaults.DEFAULT_HASH_LENGTH]; + try { + generateHash( + passwordBytes, + salt, + Argon2idDefaults.DEFAULT_ITERATIONS, + Argon2idDefaults.DEFAULT_MEMORY_KB, + Argon2idDefaults.DEFAULT_PARALLELISM, + Argon2idDefaults.DEFAULT_VERSION, + hash); + return toPhcString( + salt, + hash, + Argon2idDefaults.DEFAULT_ITERATIONS, + Argon2idDefaults.DEFAULT_MEMORY_KB, + Argon2idDefaults.DEFAULT_PARALLELISM, + Argon2idDefaults.DEFAULT_VERSION); + } finally { + Arrays.clear(passwordBytes); + Arrays.clear(salt); + Arrays.clear(hash); + } + } + + @Override + public boolean verify(String plainPassword, String hashedPassword) { + Preconditions.checkArgument( + StringUtils.isNotBlank(plainPassword), "Plain password must not be blank"); + Preconditions.checkArgument( + StringUtils.isNotBlank(hashedPassword), "Hashed password must not be blank"); + + ParsedHash parsedHash = parse(hashedPassword); + byte[] passwordBytes = plainPassword.getBytes(StandardCharsets.UTF_8); + byte[] actualHash = new byte[parsedHash.hash.length]; + try { + generateHash( + passwordBytes, + parsedHash.salt, + parsedHash.iterations, + parsedHash.memoryKb, + parsedHash.parallelism, + parsedHash.version, + actualHash); + return MessageDigest.isEqual(actualHash, parsedHash.hash); + } finally { + Arrays.clear(passwordBytes); + Arrays.clear(actualHash); Review Comment: `verify()` clears `passwordBytes` and `actualHash`, but it leaves the decoded `parsedHash.salt` and `parsedHash.hash` byte arrays in memory after verification. Since these arrays are only needed within this method, clear them in the `finally` block (after the `MessageDigest.isEqual` check) to reduce the lifetime of sensitive material in heap dumps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
