Copilot commented on code in PR #10967: URL: https://github.com/apache/gravitino/pull/10967#discussion_r3193619003
########## server-common/src/main/java/org/apache/gravitino/server/authentication/BasicAuthenticator.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.server.authentication; + +import java.nio.charset.StandardCharsets; +import java.security.Principal; +import java.util.Base64; +import org.apache.gravitino.Config; +import org.apache.gravitino.UserPrincipal; +import org.apache.gravitino.auth.AuthConstants; +import org.apache.gravitino.exceptions.BadRequestException; +import org.apache.gravitino.exceptions.UnauthorizedException; + +/** + * Basic authenticator wiring for the local authentication module. + * + * <p>The credential verification flow will be implemented in follow-up subtasks. For now, keep the + * current Basic header parsing behavior so the module can be loaded safely when {@code + * gravitino.authenticators=basic}. + */ +public class BasicAuthenticator implements Authenticator { + private static final String BASIC_AUTH_CHALLENGE = "Basic"; + + @Override + public boolean isDataFromToken() { + return true; + } + + @Override + public Principal authenticateToken(byte[] tokenData) { + if (tokenData == null) { + throw new UnauthorizedException("Empty token authorization header", BASIC_AUTH_CHALLENGE); + } + + String authData = new String(tokenData, StandardCharsets.UTF_8); + if (authData.trim().isEmpty()) { + throw new UnauthorizedException("Empty token authorization header", BASIC_AUTH_CHALLENGE); + } + + if (!authData.startsWith(AuthConstants.AUTHORIZATION_BASIC_HEADER)) { + throw new UnauthorizedException("Invalid token authorization header", BASIC_AUTH_CHALLENGE); + } + + String credential = authData.substring(AuthConstants.AUTHORIZATION_BASIC_HEADER.length()); + if (credential.trim().isEmpty()) { + throw new BadRequestException("Malformed Basic authorization header: missing credentials"); + } + + try { + String decodedCredential = + new String(Base64.getDecoder().decode(credential), StandardCharsets.UTF_8); + int separatorIndex = decodedCredential.indexOf(':'); + if (separatorIndex < 0) { + throw new BadRequestException( + "Malformed Basic authorization header: credentials must be in username:password format"); + } + + String userName = decodedCredential.substring(0, separatorIndex); + if (userName.isEmpty()) { + throw new BadRequestException( + "Malformed Basic authorization header: username must not be empty"); + } + + return new UserPrincipal(userName, authData); + } catch (IllegalArgumentException e) { + throw new BadRequestException(e, "Malformed Basic authorization header: invalid base64"); + } Review Comment: `authenticateToken` currently returns a `UserPrincipal` for any non-empty `username:password` credential without validating the password or otherwise verifying the caller. If a deployment enables `gravitino.authenticators=basic`, this effectively allows authentication as any username with any password, which is a serious security risk. If credential verification is intentionally deferred, consider failing closed (always throw `UnauthorizedException`) until the verification mechanism is implemented, or gate this behavior behind an explicit "insecure" config flag with strong warnings. ########## server-common/src/main/java/org/apache/gravitino/server/authentication/BasicAuthenticator.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.server.authentication; + +import java.nio.charset.StandardCharsets; +import java.security.Principal; +import java.util.Base64; +import org.apache.gravitino.Config; +import org.apache.gravitino.UserPrincipal; +import org.apache.gravitino.auth.AuthConstants; +import org.apache.gravitino.exceptions.BadRequestException; +import org.apache.gravitino.exceptions.UnauthorizedException; + +/** + * Basic authenticator wiring for the local authentication module. + * + * <p>The credential verification flow will be implemented in follow-up subtasks. For now, keep the + * current Basic header parsing behavior so the module can be loaded safely when {@code + * gravitino.authenticators=basic}. + */ +public class BasicAuthenticator implements Authenticator { + private static final String BASIC_AUTH_CHALLENGE = "Basic"; + + @Override + public boolean isDataFromToken() { + return true; + } + + @Override + public Principal authenticateToken(byte[] tokenData) { + if (tokenData == null) { + throw new UnauthorizedException("Empty token authorization header", BASIC_AUTH_CHALLENGE); + } + + String authData = new String(tokenData, StandardCharsets.UTF_8); + if (authData.trim().isEmpty()) { + throw new UnauthorizedException("Empty token authorization header", BASIC_AUTH_CHALLENGE); + } + + if (!authData.startsWith(AuthConstants.AUTHORIZATION_BASIC_HEADER)) { + throw new UnauthorizedException("Invalid token authorization header", BASIC_AUTH_CHALLENGE); + } + + String credential = authData.substring(AuthConstants.AUTHORIZATION_BASIC_HEADER.length()); + if (credential.trim().isEmpty()) { + throw new BadRequestException("Malformed Basic authorization header: missing credentials"); + } + + try { + String decodedCredential = + new String(Base64.getDecoder().decode(credential), StandardCharsets.UTF_8); + int separatorIndex = decodedCredential.indexOf(':'); + if (separatorIndex < 0) { + throw new BadRequestException( + "Malformed Basic authorization header: credentials must be in username:password format"); + } + + String userName = decodedCredential.substring(0, separatorIndex); + if (userName.isEmpty()) { + throw new BadRequestException( + "Malformed Basic authorization header: username must not be empty"); + } + + return new UserPrincipal(userName, authData); + } catch (IllegalArgumentException e) { + throw new BadRequestException(e, "Malformed Basic authorization header: invalid base64"); + } + } + + @Override + public void initialize(Config config) { + // no-op + } + + @Override + public boolean supportsToken(byte[] tokenData) { + return tokenData != null + && new String(tokenData, StandardCharsets.UTF_8) + .startsWith(AuthConstants.AUTHORIZATION_BASIC_HEADER); Review Comment: `supportsToken` returns false when the `Authorization` header is missing or blank, so `AuthenticationFilter` will never call `authenticateToken` in those cases. This means missing/blank headers will fall through to `UnauthorizedException("The provided credentials did not support")` and will not include a `WWW-Authenticate: Basic` challenge, conflicting with the intended behavior tested in `TestBasicAuthenticator` and described in the PR. Consider treating null/blank token data as supported (similar to `SimpleAuthenticator`) so this authenticator can emit the correct 401 + challenge for missing/blank headers. ########## server-common/src/main/java/org/apache/gravitino/server/authentication/BasicAuthenticator.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.server.authentication; + +import java.nio.charset.StandardCharsets; +import java.security.Principal; +import java.util.Base64; +import org.apache.gravitino.Config; +import org.apache.gravitino.UserPrincipal; +import org.apache.gravitino.auth.AuthConstants; +import org.apache.gravitino.exceptions.BadRequestException; +import org.apache.gravitino.exceptions.UnauthorizedException; + +/** + * Basic authenticator wiring for the local authentication module. + * + * <p>The credential verification flow will be implemented in follow-up subtasks. For now, keep the + * current Basic header parsing behavior so the module can be loaded safely when {@code + * gravitino.authenticators=basic}. + */ +public class BasicAuthenticator implements Authenticator { + private static final String BASIC_AUTH_CHALLENGE = "Basic"; + + @Override + public boolean isDataFromToken() { + return true; + } + + @Override + public Principal authenticateToken(byte[] tokenData) { + if (tokenData == null) { + throw new UnauthorizedException("Empty token authorization header", BASIC_AUTH_CHALLENGE); + } + + String authData = new String(tokenData, StandardCharsets.UTF_8); + if (authData.trim().isEmpty()) { + throw new UnauthorizedException("Empty token authorization header", BASIC_AUTH_CHALLENGE); + } + + if (!authData.startsWith(AuthConstants.AUTHORIZATION_BASIC_HEADER)) { + throw new UnauthorizedException("Invalid token authorization header", BASIC_AUTH_CHALLENGE); + } + + String credential = authData.substring(AuthConstants.AUTHORIZATION_BASIC_HEADER.length()); + if (credential.trim().isEmpty()) { + throw new BadRequestException("Malformed Basic authorization header: missing credentials"); + } + + try { + String decodedCredential = + new String(Base64.getDecoder().decode(credential), StandardCharsets.UTF_8); + int separatorIndex = decodedCredential.indexOf(':'); Review Comment: The Base64 decode uses the raw `credential` substring, which may include leading/trailing whitespace after the "Basic " scheme. RFC 7617 allows one or more spaces after the scheme, so headers like "Basic <b64>" (or with trailing spaces) would be rejected as invalid base64. Trimming (or otherwise normalizing) the credential before decoding would make parsing more robust. ########## authenticators/authenticator-basic/build.gradle.kts: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +plugins { + `maven-publish` + id("java") + id("idea") +} + +dependencies { Review Comment: The new `:authenticators:authenticator-basic` module is currently empty (no `src/main/java` sources) and only declares test dependencies, but `:server` is wired to depend on it. As a result, the module doesn’t actually provide the `BasicAuthenticator` implementation (which lives in `server-common`), and the added dependency doesn’t contribute anything. Either move the Basic authenticator implementation into this module (and have the factory load that class), or remove the module/dependency until it contains functional code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
