mengxianwen1 commented on code in PR #10980:
URL: https://github.com/apache/gravitino/pull/10980#discussion_r3198632555
##########
catalogs/catalog-lakehouse-generic/src/main/java/org/apache/gravitino/catalog/lakehouse/generic/GenericCatalogOperations.java:
##########
@@ -243,6 +248,10 @@ public Table createTable(
newProperties.put(Table.PROPERTY_LOCATION, tableLocation);
newProperties.put(Table.PROPERTY_TABLE_FORMAT, format);
+ // Merge lance.storage.* properties from catalog and schema levels
+ Map<String, String> mergedStorageProps =
mergeLanceStorageProperties(schema, properties);
Review Comment:
You're right. I'll refactor the Lance-specific logic into a dedicated class.
Thanks for your the guidance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
