roryqi commented on code in PR #11022:
URL: https://github.com/apache/gravitino/pull/11022#discussion_r3218624915
##########
plugins/idp-basic/build.gradle.kts:
##########
@@ -24,10 +24,17 @@ plugins {
}
dependencies {
+ implementation(project(":common"))
Review Comment:
Could u add a blank line here? Because next line belongs the different
segment.
##########
plugins/idp-basic/build.gradle.kts:
##########
@@ -24,10 +24,17 @@ plugins {
}
dependencies {
+ implementation(project(":common"))
implementation(libs.bcprov.jdk18on)
Review Comment:
Could u follow the alphabet order here?
##########
plugins/idp-basic/build.gradle.kts:
##########
@@ -24,10 +24,17 @@ plugins {
}
dependencies {
+ implementation(project(":common"))
implementation(libs.bcprov.jdk18on)
implementation(libs.commons.lang3)
implementation(libs.guava)
+ implementation(libs.jackson.annotations)
+ implementation(libs.jackson.databind)
+ annotationProcessor(libs.lombok)
Review Comment:
Why does lombok repeat for many times? Is it required?
##########
plugins/idp-basic/src/main/java/org/apache/gravitino/dto/requests/GroupRemoveUsersRequest.java:
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.gravitino.dto.requests;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.google.common.base.Preconditions;
+import java.util.List;
+import lombok.Builder;
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.ToString;
+import lombok.extern.jackson.Jacksonized;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.gravitino.rest.RESTRequest;
+
+/** Represents a request to remove users from a built-in IdP group. */
+@Getter
+@EqualsAndHashCode
+@ToString
+@Builder
+@Jacksonized
+public class GroupRemoveUsersRequest implements RESTRequest {
Review Comment:
I have concern about this class. I don't we should have this request. I
prefer using
```
GroupMembershipChangeRequest {
String[] additions;
String[] removals;
}
```
But we can see the next pull request.
I also don't like the order you raised the pull requests.
You raise the storage pull request first.
Then logic layer pull request.
Finally API layer pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
